Fix Gemini Tool Calling for texts returned from MethodToolCallback #3040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nlinhvu <[email protected]>
nlinhvu
force-pushed
the
gemini-functioncalling
branch
from
beacf6a to
9e2a67b
Compare
|
@nlinhvu thank you for catching this |
|
Rebased and merged at f2df87b |
|
The issue I found is slightly different from this one. When creating an exception processor like this: The exception message is passed into the ToolResponse as a plain String in the responseData field. I have submitted a fix for this in PR #4521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MethodToolCallbackcan return aString(which is Textual Json/Json String) that is not supported byjsonToStructmethod. => UpdatejsonToStructmethod with Textual Json/Json String.MethodToolCallbackrelies onDefaultToolCallResultConverterwhich is not always return Textual Json/Json String, in case of methodReturnType isvoid, it simply returns simpleString: "Done" that cannot be parsed byjsonToStruct=> UpdateDefaultToolCallResultConverteralways return Textual Json/Json String.